Trouble in Terrorist Town - a GMod gamemode

[Chief Tiger]

Well I asked you what file(s) were edited and you said just player.lua at that one line.

I changed it and it gave me that.

So I guess more than just player.lua was edited?

[Bad King Urgrain]

Nope. That was the only edited thing in the Lua between v27 and v28. If you want to see for yourself, grab v27, grab v28, and run a comparison tool on them (eg. winmerge).

[C.Mong]

diff player_v27.lua player_v28.lua > player.lua.diff

607c607
<    if ply:IsDetective() then receiver = nil end
---
>    if ply:IsActiveDetective() then receiver = nil end

Also

diff -rq terrortown270210 terrortown280210 > diff.diff

Files terrortown270210/gamemodes/terrortown/changelog.txt and terrortown280210/gamemodes/terrortown/changelog.txt differ
Files terrortown270210/gamemodes/terrortown/gamemode/player.lua and terrortown280210/gamemodes/terrortown/gamemode/player.lua differ
Files terrortown270210/gamemodes/terrortown/gamemode/shared.lua and terrortown280210/gamemodes/terrortown/gamemode/shared.lua differ

I did it for you Cheif Tiger.

[Chief Tiger]

Aha. I found the problem.

It wasn't what I edited that was causing the error, it was this line in player.lua:

if IsValid(attacker) and attacker:IsActiveDetective() and victim:IsTraitor() then

It's the credit rewarder for detectives if they kill a traitor.

[Bad King Urgrain]

In that case, the player_ext_shd.lua is probably working correctly. Which means that code could only error if the death of a player is attributed to a non-player entity (not including physics), which doesn't really happen in TTT. Maybe an NPC, or a custom SWEP that doesn't attribute its damage to the player who fired/planted/owned it (all default TTT ones do this correctly).

Anyway, it should be harmless, because if a non-player entity kills a player, all the credit reward code is unimportant, and that's the only thing that won't run due to the error.

This would prevent the error:

if IsValid(attacker) and attacker:IsPlayer() and attacker:IsActiveDetective() and victim:IsTraitor() then

[flubber]

Sorry didn't read all the readme.txt.

[Ajunk]

So when do we hear from the Fretta thing?

[Bad King Urgrain]

No date or anything has been announced, but this leads me to believe it will probably be later this month.

[JoTheShmo]

If you decide to work on it, could you make it so disguised people aren't named "Someone is disguise" in the TTT_Radio thing? Sometimes people don't realize that you are in disguise, and just think that they missed your name or lagged or something, and if you were to turn your name on before that happened, they would get away with it.
Recently I was only known to be disguised because of an "I'm with someone in a disguise."

[Nel]

Then what would they be named?  If it was your name, it would ruin the whole point of the disguise.

[Blitzy!]

Whilst I know the development for this has drawn to little more than a snail crawl if anything...

Is there any chance the scoreboard bug could be fixed for when the game is played with ttt_sherlockmode off? When Sherlock Mode isn't on, the scoreboard skews together and messes up, causing a great deal of confusion.

[that guy]

Disguise doesnt seem to work for me I press numpad enter and nothing happens.

[Blitzy!]

Bind +gm_special 11 to a key. Or go to your Keyboard options and bind "Numpad Enter" to a key, since that's what the disguise uses.

[Bad King Urgrain]

You can also bind ttt_toggle_disguise to a key.

I've put the scoreboard thing on my list of things to look at. I'm planning at least one more release fixing some of these things people have mentioned. Can't give an ETA, I'm not actively working on TTT right now.

[CrazyChicken]

I noticed an odd mapping bug with TTT, it's not that important but if you have a func_door_rotating that has the flags for opens on use and you hit it with the crowbar it will open and close, even with the ttt_settings saying it can't open doors. I'm pretty sure it won't open if its locked which is good.

[JoTheShmo]

Then what would they be named?  If it was your name, it would ruin the whole point of the disguise.

Nobody.
That way the person who pressed the radio bind would just assume they missed the disguised guy.

[Blitzy!]

Nobody.
That way the person who pressed the radio bind would just assume they missed the disguised guy.

Smart thinkin'. I'm in support of this.

[Firespray]

I got two guns for some reason...

[JoTheShmo]

Smart thinkin'. I'm in support of this.

One problem would be that "Nobody" would be associated with a guy in disguise, so if you accidentally said nobody, you might act stupidly and kill the perfectly innocent guy you happened to miss.
One plus is that glitch where you will appear with no name to certain people will be solvable just by pressing a radio bind.

What about an option to automatically run "status" every time a round starts. That way you won't have to pay too much attention to getting everyone's steam ID, but if someone RDMs them leaves, you can still get it.
I would use a clientside script, but then there's scriptenforcer to pass...

[Bad King Urgrain]

I got two guns for some reason...

http://i43.tinypic.com/2nkgj.jpg

I'm pretty sure this is a rare glitch where it shows two while it is in fact just one. So it should be purely cosmetic.