Can someone advice me what is wrong with this code?

[Mr. Wepz.]

Alright so i was doing some LUA scripting with a friend of mine who helped me but after all we dint got it working and he dont know what he did wrong to, he said "ply isent defined" or something like that but idk if thats true.. He said it should work,

Basicly what we were trying to do is that when people connect to the server and enter the game it says "player [name] joined the server with steamid [id]" in chat..
Better way to ban ppl there steam id's with ULX,

function FirstSpawn( ply )
    for k,v in pairs( player.GetAll() ) do
    v:PrintMessage( HUD_PRINTTALK, "..ply:Nick().." joined, his SteamID is: "..ply:SteamID() )

end

hook.Add( "PlayerInitialSpawn", "playerInitialSpawn", FirstSpawn )

function FirstSpawn( ply )
    for k,v in pairs( player.GetAll() ) do
    v:PrintMessage( HUD_PRINTTALK, "..ply:Nick().." joined, his SteamID is: "..ply:SteamID() )

end

hook.Add( "PlayerInitialSpawn", "playerInitialSpawn", FirstSpawn )


I hope you guys can help cuz my friend said it may had to do with TTT but im not sure of that.

Thanks!

[Cush]

    for k,v in pairs( player.GetAll() ) do
    v:PrintMessage( HUD_PRINTTALK, "..ply:Nick().." joined, his SteamID is: "..ply:SteamID() )
 

Your speech marks are all messed up and ply:Nick() shouldnt have .. before it. This should work -

function FirstSpawn( ply )
    for k,v in pairs( player.GetAll() ) do
    v:PrintMessage( HUD_PRINTTALK, ply:Nick().. " joined, his SteamID is: " ..ply:SteamID() )
 
end
 
hook.Add( "PlayerInitialSpawn", "playerInitialSpawn", FirstSpawn )

[Mr. Wepz.]

Im gonna give it a try ill hit you back soon :D

Thanks Btw for fast response :D

[Cush]

Although instead of looping through every player and printing the message whenever someone joins, you can just use PrintMessage on its own and it will print it in the chat for all players automatically.

Like this :

function FirstSpawn( ply )
    PrintMessage( HUD_PRINTTALK, ply:Nick().. " joined, his SteamID is: " ..ply:SteamID() )
end
 
hook.Add( "PlayerInitialSpawn", "playerInitialSpawn", FirstSpawn )

[Mr. Wepz.]

yeah thats actolly what i needed let me test now, see if it works.

So final it is

function FirstSpawn( ply )
    PrintMessage( HUD_PRINTTALK, ply:Nick().. " joined, his SteamID is: " ..ply:SteamID() )
end

hook.Add( "PlayerInitialSpawn", "playerInitialSpawn", FirstSpawn )
end

right?

[Cush]

Yup, I dont see any reason that wouldnt run.

*EDIT*

Wait, you added an extra 'end' at the end of it, dont need that.

[Mr. Wepz.]

Ok it works :D

function FirstSpawn( ply )
    PrintMessage( HUD_PRINTTALK, ply:Nick().. " joined, his SteamID is: " ..ply:SteamID() )
end

hook.Add( "PlayerInitialSpawn", "playerInitialSpawn", FirstSpawn )

Final code, but how about on disconnect? When somebody leaves or gets kicked etc. same as this only opposite right?

[Cush]

function PlayerDisconnect( ply )
    PrintMessage( HUD_PRINTTALK, ply:Nick().. " has disconnected, his SteamID is: " ..ply:SteamID() )
end
 
hook.Add( "PlayerDisconnected", "playerDisconnected", PlayerDisconnect )

[Mr. Wepz.]

Thanks, i must add this on a diff .lua file or can i use the same only below it? so it will end as


function FirstSpawn( ply )
    PrintMessage( HUD_PRINTTALK, ply:Nick().. " joined, his SteamID is: " ..ply:SteamID() )
end

hook.Add( "PlayerInitialSpawn", "playerInitialSpawn", FirstSpawn )

function PlayerDisconnect( ply )
    PrintMessage( HUD_PRINTTALK, ply:Nick().. " has disconnected, his SteamID is: " ..ply:SteamID() )
end

hook.Add( "PlayerDisconnected", "playerDisconnected", PlayerDisconnect )

or just new LUA file?

[Cush]

That would work fine, you can have as many functions and hooks as you want in a single lua file.

The only reason people put stuff in different files is to keep it all organised.

[Mr. Wepz.]

Ah ok then ill put it in a diffrent lua file, Thank you so much man this really helped ^^ :D

[Cush]

Nono you should put it in the same file like you had in your post, no point in having two different lua files which only have a couple of lines each.

[Mr. Wepz.]

Yeah thats true actolly, ill do that, and really thanks again ^^